feat: add manifest related structures #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
May 7, 2025
wgtmac
reviewed
May 7, 2025
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Sorry that I haven't finished the review yet. It is a busy week :(
wgtmac
reviewed
May 9, 2025
gty404
reviewed
May 10, 2025
wgtmac
reviewed
May 11, 2025
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Thanks for the update! It generally looks good to me.
src/iceberg/manifest_entry.h
Outdated
| std::unordered_map<int32_t, std::vector<uint8_t>> upper_bounds; | ||
| /// Field id: 131 | ||
| /// Implementation-specific key metadata for encryption | ||
| std::optional<std::vector<uint8_t>> key_metadata; |
Member
There was a problem hiding this comment.
Yes, I believe an empty key_metadata is enough.
gty404
approved these changes
May 12, 2025
wgtmac
reviewed
May 13, 2025
Add DataFile, ManifestEntry, ManifestFile, and ManifestList to Iceberg core. Support for parsing these data structures from Avro file will be added in future PRs.
Signed-off-by: Junwang Zhao <[email protected]>
Signed-off-by: Junwang Zhao <[email protected]>
Signed-off-by: Junwang Zhao <[email protected]>
Signed-off-by: Junwang Zhao <[email protected]>
Signed-off-by: Junwang Zhao <[email protected]>
…gthy lines" This reverts commit 7612e4a881966fbc7dc16a6d2ddeef181bc99c42.
Signed-off-by: Junwang Zhao <[email protected]>
Collaborator
Author
Member
|
No comments from my side |
Fokko
reviewed
May 19, 2025
Fokko
reviewed
May 19, 2025
Fokko
reviewed
May 19, 2025
Fokko
approved these changes
May 19, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Three minor things, apart from that, it looks good to me 👍
…files. Co-authored-by: Fokko Driesprong <[email protected]>
…sting files Co-authored-by: Fokko Driesprong <[email protected]>
zhjwpku
commented
May 20, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DataFile, ManifestEntry, ManifestFile, and ManifestList to Iceberg core.
Support for parsing these data structures from Avro file will be added in future PRs.