feat: add name mapping #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
May 9, 2025
| namespace { | ||
|
|
||
| // Helper function to join a list of field names with a dot | ||
| std::string JoinByDot(std::span<const std::string> parts) { |
Member
Author
There was a problem hiding this comment.
I tried it but it seems that Clang does not yet implement this.
zhjwpku
reviewed
May 10, 2025
| @@ -0,0 +1,61 @@ | |||
| /* | |||
Collaborator
There was a problem hiding this comment.
Should we install this header by removing the internal suffix? I don't see it being used in this PR, but in #94, it's included in visit_type.h, which is meant to be installed for type manipulation. If we don't install this header, it might lead to compilation issues.
Member
Author
There was a problem hiding this comment.
I was using it for the visitor but not it is not required. Let me remove it for now. I saw that you have added that in your PR.
zhjwpku
approved these changes
May 11, 2025
lidavidm
approved these changes
May 11, 2025
Fokko
reviewed
May 12, 2025
| transform.cc | ||
| transform_function.cc | ||
| type.cc | ||
| snapshot.cc |
Contributor
There was a problem hiding this comment.
Not a CPP guy, but why is snapshot.cc removed here? 🤔
Member
Author
There was a problem hiding this comment.
It is duplicate at line 32 :)
Fokko
approved these changes
May 12, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.