feat: add json serde to name mapping #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wgtmac
commented
May 13, 2025
wgtmac
commented
- add roundtrip json conversion to name mapping
- change MappedField to use std::shared_ptr for better usability
- use optional field_id in MappedField
lidavidm
approved these changes
May 13, 2025
wgtmac
force-pushed
the
name_mapping_json
branch
2 times, most recently
from
504e8ca to
1411373
Compare
- add roundtrip json conversion to name mapping - change MappedField to use std::shared_ptr for better usability - use optional field_id in MappedField
zhjwpku
approved these changes
May 13, 2025
src/iceberg/name_mapping.h
Outdated
| /// \brief A required list of 0 or more names for a field. | ||
| std::unordered_set<std::string> names; | ||
| /// \brief An optional Iceberg field ID used when a field's name is present in `names`. | ||
| /// TODO(gangwu): check if we need to make it optional |
Collaborator
There was a problem hiding this comment.
The TODO note can be deleted.
wgtmac
commented
May 13, 2025
Fokko
approved these changes
May 13, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.