Add the rest of the _convert_schema_if_needed calls #2300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
reviewed
Aug 8, 2025
There was a problem hiding this comment.
Thanks for the PR!
Looks like theres one more usage of _convert_schema_if_needed here
And another usage of pyarrow_to_schema here
I think we should pass format_version down in both.
I found these by checking the signature changes in #2294
These 3 functions were changed as well, but i double checked them and they are all good.
_pyarrow_to_schema_without_ids
_ConvertToIceberg
_check_pyarrow_schema_compatible
rambleraptor
force-pushed
the
issue_2270_2
branch
from
ca92837 to
bf7a5ef
Compare
|
good call. both instances fixed |
rambleraptor
force-pushed
the
issue_2270_2
branch
from
bf7a5ef to
26b3533
Compare
kevinjqliu
reviewed
Aug 9, 2025
| ], | ||
| names=["timestamp_ns", "timestamptz_ns"], | ||
|
|
||
| catalog = load_catalog("default", type="in-memory") |
There was a problem hiding this comment.
nit can we use arrow_table_schema_with_nanoseconds_timestamp_precisions here? its pretty comprehensive
Comment on lines
+2265
to
+2269
| with pytest.raises(NotImplementedError, match="Writing V3 is not yet supported"): | ||
| catalog.create_table("ns.table1", schema=table.schema, properties={"format-version": "3"}) | ||
|
|
||
| with pytest.raises(NotImplementedError, match="Writing V3 is not yet supported"): | ||
| catalog.create_table("ns.table2", schema=table2.schema, properties={"format-version": "3"}) |
There was a problem hiding this comment.
nit can we test that the same code that works for v3 doesnt work for v2. something like
with pytest.raises(NotImplementedError, match="..."):
_create_table(session_catalog, identifier, {"format-version": "2"}, schema=table.schema)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2270
This adds the rest of the _convert_schema_if_needed calls.
Rationale for this change
Are these changes tested?
Are there any user-facing changes?