Add the rest of the _convert_schema_if_needed calls #2300
Conversation
There was a problem hiding this comment.
Thanks for the PR!
Looks like theres one more usage of _convert_schema_if_needed here
And another usage of pyarrow_to_schema here
I think we should pass format_version down in both.
I found these by checking the signature changes in #2294
These 3 functions were changed as well, but i double checked them and they are all good.
_pyarrow_to_schema_without_ids
_ConvertToIceberg
_check_pyarrow_schema_compatible
rambleraptor
force-pushed
the
issue_2270_2
branch
from
ca92837 to
bf7a5ef
Compare
|
good call. both instances fixed |
rambleraptor
force-pushed
the
issue_2270_2
branch
from
bf7a5ef to
26b3533
Compare
rambleraptor
force-pushed
the
issue_2270_2
branch
2 times, most recently
from
f1461e0 to
102e58b
Compare
|
Hey @kevinjqliu, sorry this took so long! I was OOO (literally on a boat with poor WiFi...), so I'm just getting to this now. Let me know if there's anything else you need! |
|
looks like the linter errored |
rambleraptor
force-pushed
the
issue_2270_2
branch
from
102e58b to
dc5ae1d
Compare
|
Ugh, circular imports! I made a fix with a TODO. The proper solution is to move TableProperties to a separate module. Happy to do that, but that feels bigger than this PR. |
yea makes sense we can follow up and fix the TODO |
|
Thanks for the PR @rambleraptor |
Closes #2270
This adds the rest of the _convert_schema_if_needed calls.
Rationale for this change
Are these changes tested?
Are there any user-facing changes?