partition field names validation against schema field conflicts #2305
+170
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2272
Collaborator: @geruh
Rationale for this change
Implements the validation logic described in #2272 to match Java and Rust behavior for partition field name conflicts with schema fields.
This mirrors the method in Java checkAndAddPartitionName():
https://github.com/apache/iceberg/blob/4dbc7f578eee7ceb9def35ebfa1a4cc236fb598f/api/src/main/java/org/apache/iceberg/PartitionSpec.java#L392-L416
Identity transforms (
sourceColumnID != null
)- Allow schema field name conflicts only when sourced form the same fieldNon-identity (
sourceColumnID == null
)- Disallow any schema field name conflicts.In this PR
isinstance(transform, (IdentityTransform, VoidTransform))
is used to achieve the same logic as Java’ssourceColumnID
check.Are these changes tested?
Yes, all existing tests pass and added a test covering validation scenarios.
Are there any user-facing changes?
Yes. Non-identity transforms can no longer use schema field names as partition field names.