-
Notifications
You must be signed in to change notification settings - Fork 351
Add between operator #2335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add between operator #2335
Conversation
acd1b28
to
ee8f952
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for adding this
looks like the linter is breaking CI, can you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Could you do make lint
again?
markdownlint.............................................................Failed
- hook id: markdownlint
- files were modified by this hook
And put the PR in "review" instead of draft
Running this locally already passes everything, I'll try rebasing from ❯ make lint
poetry run pre-commit run --all-files
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
debug statements (python)................................................Passed
check yaml...............................................................Passed
check python ast.........................................................Passed
ruff (legacy alias)......................................................Passed
ruff format..............................................................Passed
mypy.....................................................................Passed
markdownlint.............................................................Passed
pydocstyle...............................................................Passed
flynt....................................................................Passed
codespell................................................................Passed Edit: after rebasing, looks like the markdown errors were caused by another PR's change – I've fixed the linting errors in this PR. |
5918924
to
d0c11c8
Compare
d0c11c8
to
376ca2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for working on this @jtuglu1
Should we also add a small section on the expression page?
Sure. It doesn't appear that documentation for this belongs in |
3702b54
to
8223936
Compare
Rationale for this change
Fixes #792
Are these changes tested?
Are there any user-facing changes?
Add
BETWEEN
operator