-
Notifications
You must be signed in to change notification settings - Fork 343
Metadata Log Entries metadata table #667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
HonahX
merged 20 commits into
apache:main
from
kevinjqliu:kevinjqliu/metadata_log_entries
Jun 26, 2024
Merged
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9a0423d
add metadata_entries table with tests
kevinjqliu ecec57e
make test work
kevinjqliu 9e506c2
remove comment
kevinjqliu 9c77d57
add doc
kevinjqliu b26f08f
make lint
kevinjqliu 58b0609
comment
kevinjqliu f7dd165
comment
kevinjqliu 4655c97
use pa.field and set nullable properly
kevinjqliu d989802
Merge branch 'main' into kevinjqliu/metadata_log_entries
kevinjqliu 8613c2e
use table snapshot_as_of_timestamp instead
kevinjqliu f45f2ea
default sequence_number to 0
kevinjqliu 2d417da
improve test
kevinjqliu 502e5d8
improve docs
kevinjqliu 1cd5f93
add comment
kevinjqliu 3fe675d
fix tests with string output for sequence-number
kevinjqliu 6ce55f4
comment
kevinjqliu aa068ff
revert INITIAL_SEQUENCE_NUMBER changes
kevinjqliu ab74a3e
exclude sequence_number for v1
kevinjqliu f274ef9
inline function
kevinjqliu a338e17
test_serialize_snapshot_without_sequence_number
kevinjqliu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this line acts more like https://github.com/apache/iceberg/blob/8a70fe0ff5f241aec8856f8091c77fdce35ad256/core/src/main/java/org/apache/iceberg/MetadataLogEntriesTable.java#L62-L66.
Just curious the reason that you mention
addPreviousFile
here, which seem to be more relevant when we update the metadata_log during table commit.BTW, this reminds me that currently non-rest catalog does not update the metadata_log field during commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! I link the wrong code. I was trying to find all the places where the metadata log was modified