Scan Delete Support Part 5: Positional Delete Parsing#1011
Merged
sdd merged 1 commit intoapache:mainfrom Jun 30, 2025
Merged
Conversation
sdd
force-pushed
the
feat/delete-file-pos-del-parsing
branch
from
52d3e2c to
a14c3f2
Compare
sdd
force-pushed
the
feat/delete-file-pos-del-parsing
branch
3 times, most recently
from
e7f9102 to
efc45e5
Compare
jonathanc-n
reviewed
Mar 14, 2025
sdd
force-pushed
the
feat/delete-file-pos-del-parsing
branch
2 times, most recently
from
643f47a to
cfe6a91
Compare
sdd
force-pushed
the
feat/delete-file-pos-del-parsing
branch
3 times, most recently
from
5504434 to
decef64
Compare
sdd
force-pushed
the
feat/delete-file-pos-del-parsing
branch
3 times, most recently
from
343b034 to
7b755fd
Compare
This was referenced May 9, 2025
sdd
force-pushed
the
feat/delete-file-pos-del-parsing
branch
from
7ea25cb to
fc58a4f
Compare
17 tasks
sdd
force-pushed
the
feat/delete-file-pos-del-parsing
branch
5 times, most recently
from
4f8582f to
18fb170
Compare
Contributor
|
Hi, @sdd Would you mind to rebase this pr? |
Contributor
Author
…nal delete functionality
sdd
force-pushed
the
feat/delete-file-pos-del-parsing
branch
from
18fb170 to
ac36f29
Compare
Contributor
Author
|
@liurenjie1024 I've rebased this and it is ready to go. |
Contributor
Author
|
@liurenjie1024 / @Xuanwo please review when you get chance. The previous PRs are useless on their own without this small one and the small follow-up PR, #1017. |
liurenjie1024
approved these changes
Jun 30, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @sdd for this pr, LGTM! Just one minor nit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the series of scan delete file support PRs.
DeleteFileManagercrates/integration_tests/tests/shared_tests/read_positional_deletes.rsto include a working end-to-end test that processes positional deletesIssue: #630