feat: drop column for schema evolution #1582
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
force-pushed
the
hjiang/delete-column-implementation
branch
from
832e327 to
cbdb100
Compare
dentiny
force-pushed
the
hjiang/delete-column-implementation
branch
from
cbdb100 to
477519e
Compare
dentiny
commented
Aug 6, 2025
| /// # Returns | ||
| /// | ||
| /// Returns the `UpdateSchema` with the delete operation staged. | ||
| pub fn delete_column(&mut self, column_name: Vec<String>) -> Result<&mut Self> { |
There was a problem hiding this comment.
One thing I'm hesitant about is, is it better to provide a transaction action SetSchemaAction.
There was a problem hiding this comment.
Thanks @dentiny for adding this pr! The implementation is incorrect, please take other actions as reference. In general, all actions methods are used as builder method to store changes, and actual validation and change happens in commit method.
| /// # Returns | ||
| /// | ||
| /// Returns the `UpdateSchema` with the delete operation staged. | ||
| pub fn delete_column(&mut self, column_name: Vec<String>) -> Result<&mut Self> { |
There was a problem hiding this comment.
Suggested change
| pub fn delete_column(&mut self, column_name: Vec<String>) -> Result<&mut Self> { | |
| pub fn drop_column(&mut self, column_name: Vec<String>) -> Result<&mut Self> { |
There was a problem hiding this comment.
I think the column_name to be String would be enough.
There was a problem hiding this comment.
The implementation is incorrect. All changes should happen in the commit method.
There was a problem hiding this comment.
Gotcha, updated. Thank you!
dentiny
changed the title
dentiny
force-pushed
the
hjiang/delete-column-implementation
branch
from
72bb406 to
57531f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
I want to take over @jonathanc-n 's previous work on schema evolution: already contacted him offline.
Previous PR for reference: #1172
In this PR, I implemented the column deletion logic, which is the simplest part; and integrate with the new transaction API.
Are these changes tested?
Yes, unit tests added.