-
Notifications
You must be signed in to change notification settings - Fork 331
feat(datafusion): implement the project node to add the partition columns #1602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fvaleye
wants to merge
8
commits into
apache:main
Choose a base branch
from
fvaleye:feature/implement-project-node-for-insert-into-datafusion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+572
−5
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4d59f87
feat(datafusion): implement the project node to add the partition col…
fvaleye d930df9
Merge branch 'main' into feature/implement-project-node-for-insert-in…
fvaleye 803199a
feat(datafusion): adapt IcebergProjectExec to use one partition colum…
fvaleye bc805db
Merge branch 'main' into feature/implement-project-node-for-insert-in…
fvaleye 531388f
feat(datafusion): add the project_with_partition main entrypoint and …
fvaleye bdc6aae
feat(datafusion): reuse RecordBatchProjector for project.
fvaleye d4fd336
refactor: simplify RecordBatchProjector and optimize partition calcul…
fvaleye ac0fd57
Merge branch 'main' into feature/implement-project-node-for-insert-in…
fvaleye File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -29,7 +29,7 @@ mod truncate; | |||||
mod void; | ||||||
|
||||||
/// TransformFunction is a trait that defines the interface for all transform functions. | ||||||
pub trait TransformFunction: Send + Sync { | ||||||
pub trait TransformFunction: Send + Sync + std::fmt::Debug { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
It's better to keep style consistent with others. |
||||||
/// transform will take an input array and transform it into a new array. | ||||||
/// The implementation of this function will need to check and downcast the input to specific | ||||||
/// type. | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to make this pub?