feat: support more partition transformations for PartitionSpec::partition_to_path #1730
+29
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnpw
changed the title
|
Hi @liurenjie1024, can I get a review for this |
| pub(crate) fn partition_to_path(&self, data: &Struct, schema: SchemaRef) -> String { | ||
| /// Returns partition path string containing partition type and partition | ||
| /// value as key-value pairs. | ||
| pub fn partition_to_path(&self, data: &Struct, schema: SchemaRef) -> String { |
There was a problem hiding this comment.
Why we need to make this pub? It's used internally by LocationGenerator
There was a problem hiding this comment.
Hi @liurenjie1024, this is helpful if user-code is using as iceberg-rs as a low-level library. In my particular case, I want to split my data into chunks based on the partition value, hence the need to generate partition path.
I see that PartitionKey::to_path effectively achieves the same and provides partition path.
liurenjie1024
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Transform::to_human_stringAre these changes tested?
Updated existing unit test