feat(arrow): support ArrowReaderOptions in get_metadata #2003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xbattlax
force-pushed
the
support-arrow-reader-options
branch
from
32f3eca to
126011a
Compare
pratik0316
reviewed
Jan 11, 2026
Comment on lines
+45
to
+52
| arrow-arith = "57.1" | ||
| arrow-array = "57.1" | ||
| arrow-buffer = "57.1" | ||
| arrow-cast = "57.1" | ||
| arrow-ord = "57.1" | ||
| arrow-schema = "57.1" | ||
| arrow-select = "57.1" | ||
| arrow-string = "57.1" |
There was a problem hiding this comment.
In the associated linked issue: #1934
I see @lgingerich mentioned
so there is no crate dependency upgrade work that needs done
do we still need this pckage upgrade to be done as a part of this change
Contributor
Author
There was a problem hiding this comment.
Yes, the upgrade to 57.1 is required. The ArrowReaderOptions::metadata_options() method used in this PR was only exposed starting in arrow 57.1 (see apache/arrow-rs#7393). Without the upgrade, the code won't compile.
Respect ArrowReaderOptions by extracting metadata_options and passing it to ParquetMetaDataReader via with_metadata_options(). This allows callers to configure metadata decoding behavior. This change requires parquet 57.1.0 which added the ParquetMetaDataReader::with_metadata_options() API. Changes: - Update arrow and parquet dependencies from 57.0 to 57.1 - Update bindings/python/Cargo.lock for the new versions - Use metadata_options from ArrowReaderOptions in get_metadata Closes apache#1934
xbattlax
force-pushed
the
support-arrow-reader-options
branch
from
65c2f99 to
1f0add9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Respect
ArrowReaderOptionsinArrowFileReader::get_metadata()by extractingmetadata_optionsand passing it toParquetMetaDataReaderviawith_metadata_options().Changes
bindings/python/Cargo.lockfor the new versionsmetadata_optionsfrom theArrowReaderOptionsparameterParquetMetaDataReader::with_metadata_options()Notes
The
ParquetMetaDataReader::with_metadata_options()API was added in parquet 57.1.0.Security Audit
The security audit failure (RUSTSEC-2026-0001) is a pre-existing issue unrelated to this PR. It affects the
rkyvdependency and is being addressed in #1994.Closes #1934