feat(cluster): Impl VSR view_change
#2546
Open
+845
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishvishal
changed the title
view_changeview_change
numinnex
requested changes
Jan 10, 2026
| pub checksum_padding: u128, | ||
| pub checksum_body: u128, | ||
| pub checksum_body_padding: u128, | ||
| pub nonce_reserved: u128, |
Contributor
There was a problem hiding this comment.
We are not going to be using thatr nonce, get rid of it from all of the view change headers.
| /// The view number when this replica's status was last normal. | ||
| /// This is the key field for log selection: the replica with the | ||
| /// highest log_view has the most authoritative log. | ||
| pub log_view: u32, |
Contributor
There was a problem hiding this comment.
We won't need this field for now, get rid of it.
| self.replica_count | ||
| } | ||
|
|
||
| pub fn log_view(&self) -> u32 { |
Contributor
There was a problem hiding this comment.
Lets remove log_view from the VsrConsensus struct
Contributor
|
I've left a few comments for now, will have probably some more, but we have to start thinking how will the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
view_changefrom VSR-revisited paper.