refactor(go): refactor WithTLS#2957
Merged
mmodzelewski merged 3 commits intoapache:masterfrom Mar 17, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2957 +/- ##
============================================
+ Coverage 70.35% 70.47% +0.11%
+ Complexity 925 776 -149
============================================
Files 1050 1041 -9
Lines 86936 86181 -755
Branches 64491 62443 -2048
============================================
- Hits 61167 60734 -433
+ Misses 23260 22931 -329
- Partials 2509 2516 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
de9f697 to
a142043
Compare
mmodzelewski
approved these changes
Mar 17, 2026
numinnex
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale
Currently, the TLS options requiring a user to call
WithTLS(true)in addition toWithTLSDomainorWithTLSCAFile. This is redundant and error-prone. If a user provides a domain or a CA file, the intent to use TLS is already clear.We can use nested option pattern for it, therefore we can create client like this:
What changed?
Local Execution
AI Usage