Skip to content

feat(partitions): add poll_messages support to simulator#2960

Open
krishvishal wants to merge 4 commits intoapache:masterfrom
krishvishal:partition-sim
Open

feat(partitions): add poll_messages support to simulator#2960
krishvishal wants to merge 4 commits intoapache:masterfrom
krishvishal:partition-sim

Conversation

@krishvishal
Copy link
Contributor

@krishvishal krishvishal commented Mar 17, 2026

Summary

  • Implement poll_messages, store_consumer_offset, get_consumer_offset, and offsets on IggyPartition, wired through Simulator.
  • Fix send_messages client wire format to emit 64-byte IggyMessage headers and 16-byte indexes.
  • Fix StoreConsumerOffset replication: add consumer_kind byte so consumer group offsets route to the correct map.
  • Enforce committed-offset guard on PollingKind::Timestamp polling

Closes #2961

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 0% with 231 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.17%. Comparing base (a1045c3) to head (4cf983b).

Files with missing lines Patch % Lines
core/partitions/src/iggy_partition.rs 0.00% 114 Missing ⚠️
core/simulator/src/main.rs 0.00% 42 Missing ⚠️
core/simulator/src/client.rs 0.00% 33 Missing ⚠️
core/simulator/src/lib.rs 0.00% 27 Missing ⚠️
core/partitions/src/iggy_partitions.rs 0.00% 15 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2960      +/-   ##
============================================
- Coverage     70.38%   70.17%   -0.21%     
  Complexity      925      925              
============================================
  Files          1050     1050              
  Lines         86942    87166     +224     
  Branches      64492    64726     +234     
============================================
- Hits          61190    61168      -22     
- Misses        23246    23481     +235     
- Partials       2506     2517      +11     
Flag Coverage Δ
csharp 67.43% <ø> (-0.21%) ⬇️
go 36.38% <ø> (ø)
java 61.91% <ø> (ø)
node 91.28% <ø> (-0.26%) ⬇️
python 81.43% <ø> (ø)
rust 70.36% <0.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
core/partitions/src/iggy_partitions.rs 0.00% <0.00%> (ø)
core/simulator/src/lib.rs 0.00% <0.00%> (ø)
core/simulator/src/client.rs 0.00% <0.00%> (ø)
core/simulator/src/main.rs 0.00% <0.00%> (ø)
core/partitions/src/iggy_partition.rs 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@krishvishal
Copy link
Contributor Author

FAIL [   0.555s] (1041/1649) integration::mod cli::personal_access_token::test_pat_login_options::should_be_successful
FAIL [   0.224s] (1051/1649) integration::mod cli::system::test_cli_session_scenario::should_be_successful

Looks like flaky tests.

@hubcio
Copy link
Contributor

hubcio commented Mar 17, 2026

@krishvishal i will check that.

@hubcio
Copy link
Contributor

hubcio commented Mar 17, 2026

This should fix the problem with flaky test, I think... #2963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend simulator to support partition operations

2 participants