feat(partitions): add poll_messages support to simulator#2960
Open
krishvishal wants to merge 4 commits intoapache:masterfrom
Open
feat(partitions): add poll_messages support to simulator#2960krishvishal wants to merge 4 commits intoapache:masterfrom
krishvishal wants to merge 4 commits intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #2960 +/- ##
============================================
- Coverage 70.38% 70.17% -0.21%
Complexity 925 925
============================================
Files 1050 1050
Lines 86942 87166 +224
Branches 64492 64726 +234
============================================
- Hits 61190 61168 -22
- Misses 23246 23481 +235
- Partials 2506 2517 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
Looks like flaky tests. |
Contributor
|
@krishvishal i will check that. |
Contributor
|
This should fix the problem with flaky test, I think... #2963 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
poll_messages,store_consumer_offset,get_consumer_offset, andoffsetsonIggyPartition, wired throughSimulator.send_messagesclient wire format to emit 64-byte IggyMessage headers and 16-byte indexes.StoreConsumerOffsetreplication: add consumer_kind byte so consumer group offsets route to the correct map.PollingKind::TimestamppollingCloses #2961