Skip to content

Conversation

@tinazhouhui
Copy link
Contributor

@tinazhouhui tinazhouhui commented Apr 16, 2025

⚠️   Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have npm run build and npm run serve locally before submitting this PR
  • I have read through the Contributing Documentation

Summary

This is an additional PR to make the blog post more visible. I have also taken the liberty to update the documentation for contributing so that this extra step is included. For more info see here.

Does this close any open issues?

No.

klesh
klesh previously approved these changes Apr 17, 2025
Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@klesh
Copy link
Contributor

klesh commented Apr 17, 2025

Hi, the build has failed, you can find the error message on https://github.com/apache/incubator-devlake-website/actions/runs/14487459892/job/40696009403?pr=796

@tinazhouhui
Copy link
Contributor Author

Hi, the build has failed, you can find the error message on https://github.com/apache/incubator-devlake-website/actions/runs/14487459892/job/40696009403?pr=796

I guess this is the anwer to my question regarding cover images ;) PR updated with instructions as well.

@tinazhouhui tinazhouhui requested a review from klesh April 23, 2025 09:12
Copy link
Contributor

@d4x1 d4x1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, Thanks for your contribution.

@klesh klesh merged commit c796669 into apache:main Apr 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants