fix: allow 0 idle database connection #8522
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow having an idle connection value of 0 or less as this is supported by the SQL driver documented here which points here.
Does this close any open issues?
No
Other Information
In my setup we are using AWS Aurora Serverless v2. One important property of this technology is that it automatically scales the cluster depending on load. It can scale down to 0 and then we don't pay for the use of the database; which we want in order to save money.
Unfortunately devlake doesn't allow having less than 1 idle connection. This PR fixes that by removing the condition from the code and relying on the SQL driver to manage the connection pooling.