Skip to content

Conversation

petkostas
Copy link
Contributor

@petkostas petkostas commented Oct 1, 2025

Summary

This PR extends the CI/CD analytics to support more granular result categorization by adding Canceled and Skipped result types alongside the existing Success and Failure types. This provides better insights into CI/CD pipeline outcomes and more accurate DORA metrics.

Please note this covers for now:

  • GitHub (✅ Veridfied)
  • BitBucket (⚠️ Unverified)
  • CircleCI (⚠️ Unverified)
  • Gitlab (⚠️ Unverified)
  • Bamboo (⚠️ Unverified)
  • Jenkins (⚠️ Unverified)
  • Azure DevOps (⚠️ Unverified)

Does this close any open issues?

Closes #8570

Screenshots

Screenshot 2025-10-01 at 16 55 40

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 1, 2025
@petkostas petkostas requested a review from klesh October 1, 2025 15:00
@petkostas petkostas force-pushed the chore/add-extra-pipeline-status branch from 28f9192 to d292ecc Compare October 1, 2025 15:02
@dosubot dosubot bot added component/plugins This issue or PR relates to plugins devops Something about CI/CD (devops) pr-type/feature-development This PR is to develop a new feature priority/medium This issue is medium important labels Oct 1, 2025
- Extends existing statuses for ci/cd for GitHub, GitLab, BitBucket and
CircleCI
- Update e2e tests
@petkostas petkostas force-pushed the chore/add-extra-pipeline-status branch 10 times, most recently from 7dce648 to 7030919 Compare October 1, 2025 16:38
@petkostas petkostas removed the request for review from klesh October 1, 2025 16:39
@petkostas petkostas marked this pull request as draft October 1, 2025 16:39
@petkostas petkostas force-pushed the chore/add-extra-pipeline-status branch from 7030919 to be54217 Compare October 1, 2025 16:46
- Extend to other SVN providers
- Fix failing e2e
@petkostas petkostas force-pushed the chore/add-extra-pipeline-status branch from be54217 to 1f566ef Compare October 1, 2025 16:59
@petkostas petkostas requested a review from klesh October 1, 2025 17:05
@petkostas petkostas marked this pull request as ready for review October 2, 2025 12:55
@petkostas
Copy link
Contributor Author

@klesh I can only verify the GitHub part since that is what I have access too (I could check with GitLab but it is been a while since I used it so it will require more time to test).
Let me know if you would prefer to keep only the GitHub changes for now and then gradually look into introducing the other statuses for the other data sources.

@klesh
Copy link
Contributor

klesh commented Oct 9, 2025

@petkostas Thank for the information.
Testing new features for all data sources is time-consuming, sometimes impossible due to paywalls or data availability. I think it is OK to push it out when it is working properly on 1 data source.

Adding new statuses for all data sources should be OK as long as it doesn't break any existing dashboards IMO. @Startrekzky Do you recall any dashboards depending on the cicd_pipelines.status being SUCCESS, FAILURE, and `` only? In other words, would any dashboard break if new statuses CANCELED and `SKIPPED` were introduced?

@petkostas
Copy link
Contributor Author

@petkostas Thank for the information. Testing new features for all data sources is time-consuming, sometimes impossible due to paywalls or data availability. I think it is OK to push it out when it is working properly on 1 data source.

Adding new statuses for all data sources should be OK as long as it doesn't break any existing dashboards IMO. @Startrekzky Do you recall any dashboards depending on the cicd_pipelines.status being SUCCESS, FAILURE, and `` only? In other words, would any dashboard break if new statuses CANCELED and `SKIPPED` were introduced?

Thanks @klesh I think it's best to move with GitHub only and then gradually introduce the others through maybe contributors who have access to the other data sources.
I will re-factor the existing PR to include only GitHub related changes, I think it will also help the changes reach the main branch faster 😃

@klesh
Copy link
Contributor

klesh commented Oct 10, 2025

@petkostas Thank for the information. Testing new features for all data sources is time-consuming, sometimes impossible due to paywalls or data availability. I think it is OK to push it out when it is working properly on 1 data source.
Adding new statuses for all data sources should be OK as long as it doesn't break any existing dashboards IMO. @Startrekzky Do you recall any dashboards depending on the cicd_pipelines.status being SUCCESS, FAILURE, and `` only? In other words, would any dashboard break if new statuses CANCELED and `SKIPPED` were introduced?

Thanks @klesh I think it's best to move with GitHub only and then gradually introduce the others through maybe contributors who have access to the other data sources. I will re-factor the existing PR to include only GitHub related changes, I think it will also help the changes reach the main branch faster 😃

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/plugins This issue or PR relates to plugins devops Something about CI/CD (devops) pr-type/feature-development This PR is to develop a new feature priority/medium This issue is medium important size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][CI/CD] CANCELLED as pipeline result

2 participants