Skip to content

Conversation

@ysinghc
Copy link
Contributor

@ysinghc ysinghc commented Nov 20, 2025

⚠️ Pre Checklist

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/feature-development.

Summary

This PR introduces support for GitHub OAuth token refresh logic in the GitHub plugin. It adds new fields to the GithubConnection model for storing refresh tokens and expiry times, and implements a TokenProvider with proactive and reactive refresh capabilities. The HTTP client now uses a custom RoundTripper to handle token refresh on 401 responses and near-expiry tokens. Relevant tests and migration scripts are included.

Does this close any open issues?

Closes #8532 (replace with actual issue number if applicable)

Screenshots

N/A

Other Information

  • Migration script added for new fields in the database.
  • Unit and integration tests cover token refresh scenarios.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. component/plugins This issue or PR relates to plugins pr-type/feature-development This PR is to develop a new feature labels Nov 20, 2025
@ysinghc ysinghc closed this Nov 27, 2025
@ysinghc ysinghc force-pushed the feat/github-refresh-tokens branch from 5b88b01 to cfe519c Compare November 27, 2025 13:17
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Nov 27, 2025
@ysinghc ysinghc deleted the feat/github-refresh-tokens branch November 27, 2025 13:17
@ysinghc ysinghc restored the feat/github-refresh-tokens branch November 27, 2025 13:17
@ysinghc
Copy link
Contributor Author

ysinghc commented Nov 27, 2025

I will review the fixes needed for the failing tests. and update the migration scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/plugins This issue or PR relates to plugins pr-type/feature-development This PR is to develop a new feature size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Github] Refresh token for GitHub Apps authentication

1 participant