[GLUTEN-10349] Remove the unnecessary Set and use enum directly #10350
+27
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
|
ping @marin-ma |
|
LGTM. @zhztheplayer Could you take a look? Thanks! |
zml1206
reviewed
Aug 13, 2025
| @@ -193,7 +192,7 @@ protected void writeImpl(Iterator<Product2<K, V>> records) { | |||
| new Spiller() { | |||
| @Override | |||
| public long spill(MemoryTarget self, Spiller.Phase phase, long size) { | |||
| if (!Spillers.PHASE_SET_SPILL_ONLY.contains(phase)) { | |||
| if (!Spiller.Phase.SPILL.equals(phase)) { | |||
There was a problem hiding this comment.
Nit: Can you unify the code style? Same as above, using pattern matching, thanks
zml1206
reviewed
Aug 13, 2025
| @@ -87,7 +86,7 @@ public ColumnarBatchOutIterator createKernelWithBatchIterator( | |||
| new Spiller() { | |||
| @Override | |||
| public long spill(MemoryTarget self, Spiller.Phase phase, long size) { | |||
| if (!Spillers.PHASE_SET_SPILL_ONLY.contains(phase)) { | |||
| if (!Spiller.Phase.SPILL.equals(phase)) { | |||
| return 0L; | |||
There was a problem hiding this comment.
Java style recommends if if there is only one branch.
There was a problem hiding this comment.
Oh, these two are java classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes remove the unnecessary
Setand use enum directly(Fixes: #10349)
How was this patch tested?
unit tests, integration tests, manual tests