[GLUTEN-10397][VL] Add timestampadd support #10400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zml1206
commented
Aug 12, 2025
Comment on lines
+543
to
+548
| checkEvaluation( | ||
| TimestampAdd( | ||
| "DAY", | ||
| Literal(-1), | ||
| Literal(repeatedTime + 24 * MICROS_PER_HOUR, TimestampType)), | ||
| repeatedTime - MICROS_PER_HOUR) |
There was a problem hiding this comment.
Original test:
checkEvaluation(
TimestampAdd(
"DAY",
Literal(-1),
Literal(repeatedTime + 24 * MICROS_PER_HOUR, TimestampType)),
repeatedTime)
zml1206
commented
Aug 12, 2025
Comment on lines
+559
to
+564
| checkEvaluation( | ||
| TimestampAdd( | ||
| "MONTH", | ||
| Literal(-1), | ||
| Literal(repeatedTime + 30 * MICROS_PER_DAY, TimestampType)), | ||
| repeatedTime - MICROS_PER_HOUR) |
There was a problem hiding this comment.
Original test:
checkEvaluation(
TimestampAdd(
"MONTH",
Literal(-1),
Literal(repeatedTime + 30 * MICROS_PER_DAY, TimestampType)),
repeatedTime)
|
Run Gluten ClickHouse CI on ARM |
fix fix fix fix
|
Run Gluten ClickHouse CI on ARM |
| @@ -631,6 +631,7 @@ class ClickHouseTestSettings extends BackendTestSettings { | |||
| .exclude("SPARK-37552: convert a timestamp_ntz to another time zone") | |||
| .exclude("SPARK-38195: add a quantity of interval units to a timestamp") | |||
| .exclude("SPARK-38284: difference between two timestamps in units") | |||
| .exclude("SPARK-42635: timestampadd near daylight saving transition") | |||
There was a problem hiding this comment.
Why CH backend also exclude the test? What's the change for CH?
There was a problem hiding this comment.
Previously, CH only supported 3.3. This spark test was added in 3.4.
jinchengchenghh
approved these changes
Aug 13, 2025
|
@jinchengchenghh Thanks, merge into main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Fixes: #10397)
How was this patch tested?
UT.