[GLUTEN-10950][VL][FOLLOWUP] Fix missing time unit in hadoop-aws time configuration (pre-3.4 versions) #11329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnection.establish.timeout'
Contributor
Author
zml1206
reviewed
Dec 26, 2025
Contributor
zml1206
left a comment
zml1206
left a comment
There was a problem hiding this comment.
Could you also support the other time config mentioned in #10951 (comment)? Thanks.
zml1206
reviewed
Dec 26, 2025
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxTransformerApi.scala
Outdated
Show resolved
Hide resolved
Contributor
|
Can you add the two configs as well? |
Contributor
Author
@zml1206 @FelixYBW use map to store config key to its default time unit. |
zml1206
reviewed
Jan 8, 2026
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxTransformerApi.scala
Outdated
Show resolved
Hide resolved
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxTransformerApi.scala
Outdated
Show resolved
Hide resolved
zml1206
reviewed
Jan 8, 2026
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxTransformerApi.scala
Outdated
Show resolved
Hide resolved
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxTransformerApi.scala
Outdated
Show resolved
Hide resolved
added 2 commits
January 8, 2026 17:17
…a.multipart.purge.age unit
zml1206
approved these changes
Jan 8, 2026
Contributor
zml1206
left a comment
zml1206
left a comment
There was a problem hiding this comment.
LGTM, thanks, awaiting CI.
Contributor
|
Please use |
zml1206
reviewed
Jan 8, 2026
| if (NumberUtils.isCreatable(s3sConnectionTimeout)) { | ||
| nativeConfMap.put("spark.hadoop.fs.s3a.connection.timeout", s"${s3sConnectionTimeout}ms") | ||
| // S3A configurations that require time units for Velox. | ||
| // Hadoop-aws versions before 3.3.6 do not include time units by default. |
Contributor
There was a problem hiding this comment.
Why modify it? It should be before version 3.4. Suggestion:
Some configurations in Hadoop-aws versions before 3.4 do not include time units.
This reverts commit 68f184e.
xumanbu
changed the title
zml1206
reviewed
Jan 9, 2026
| s3aTimeConfigs.foreach { | ||
| case (configKey, defaultUnit) => | ||
| val configValue = nativeConfMap.get(configKey) | ||
| if (configValue != null && NumberUtils.isCreatable(configValue)) { |
Contributor
There was a problem hiding this comment.
configValue != null is redundant, NumberUtils.isCreatable contains null checks.
wForget
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
FOLLOWUP Fix: #10950
How was this patch tested?
No need