[VL] Spark 3.5 + Delta 3.3: Unify code style with Gluten codebase #11596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we followed the Delta's original Scala code style for Delta support code that was originated from Delta's codebase, this doesn't suit well for long term maintenance as we had to disable code style checking for these files. The PR removes the `spotless:off` marks to enable linters for these files. The code will be complying with Gluten's code style then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Previously we followed the Delta's original Scala code style for Delta support code that was originated from Delta's codebase, this doesn't suit well for long term maintenance as we had to disable code style checking for these files.
The PR removes the
spotless:offmarks to enable linters for these files. The code will be complying with Gluten's code style then.Was this patch authored or co-authored using generative AI tooling?
No.