Skip to content

fix: introducing auto-download .so and makefile #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: release-1.7.0
Choose a base branch
from
Open

fix: introducing auto-download .so and makefile #339

wants to merge 2 commits into from
+398 −653

Conversation

@Pengzna
Copy link

@Pengzna Pengzna commented Nov 8, 2025

New files added:

  1. scripts/download_binaries.sh - Scripts for automatically downloading supervisord and protoc
  2. Makefile - Provides build commands such as make init and make build

Modified files:

  1. build.sh - Added steps for automatically downloading and generating assets
  2. README.md - Updated build instructions
  3. README.zh-CN.md - Updated Chinese build instructions

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. feature New feature labels Nov 8, 2025
Ethereal-O
Ethereal-O approved these changes Nov 8, 2025
View reviewed changes
Copy link
Contributor

@Ethereal-O Ethereal-O left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Ethereal-O Ethereal-O Ethereal-O approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature New feature size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pengzna @Ethereal-O