-
Notifications
You must be signed in to change notification settings - Fork 575
fix: use slim docker image #2903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VGalaxies
previously approved these changes
Nov 6, 2025
imbajin
previously approved these changes
Nov 6, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2903 +/- ##
============================================
- Coverage 35.79% 31.24% -4.56%
- Complexity 398 500 +102
============================================
Files 811 813 +2
Lines 67831 68715 +884
Branches 8798 8973 +175
============================================
- Hits 24281 21469 -2812
- Misses 40980 44900 +3920
+ Partials 2570 2346 -224 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
imbajin
approved these changes
Nov 6, 2025
|
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label |
VGalaxies
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use slim docker image to reduce image size.
After comparision,
jammyis better thanalpinesincejammysupport more platforms.docker manifest inspect eclipse-temurin:11-jre-alpine 12:07:07 { "schemaVersion": 2, "mediaType": "application/vnd.oci.image.index.v1+json", "manifests": [ { "mediaType": "application/vnd.oci.image.manifest.v1+json", "size": 1943, "digest": "sha256:6cde7e6ae3c23c3636f3fb4b92836d1323c13929d9ee27da1885cc231c086101", "platform": { "architecture": "amd64", "os": "linux" } }, { "mediaType": "application/vnd.oci.image.manifest.v1+json", "size": 840, "digest": "sha256:5eb97410da75fced84bb8bbb4b2f6166c6d99f7fe42fe04ec23356e46e703f0c", "platform": { "architecture": "unknown", "os": "unknown" } } ] }docker manifest inspect eclipse-temurin:11-jre-jammy 35s 12:07:33 { "schemaVersion": 2, "mediaType": "application/vnd.oci.image.index.v1+json", "manifests": [ { "mediaType": "application/vnd.oci.image.manifest.v1+json", "size": 1940, "digest": "sha256:66954426decc542a63c58421445028b5af5471063eac45bc7d845fa772db3e56", "platform": { "architecture": "amd64", "os": "linux" } }, { "mediaType": "application/vnd.oci.image.manifest.v1+json", "size": 841, "digest": "sha256:fd5e03e50a0632b8a7d6dc4f9e0002a42a765a755a86942e9040c08041e3aa99", "platform": { "architecture": "unknown", "os": "unknown" } }, { "mediaType": "application/vnd.oci.image.manifest.v1+json", "size": 1942, "digest": "sha256:ec3df5adcc48428b02d3a7db2602bffbdfc3e92ba6db3e7fd0d593d547f99b14", "platform": { "architecture": "arm", "os": "linux", "variant": "v7" } }, { "mediaType": "application/vnd.oci.image.manifest.v1+json", "size": 841, "digest": "sha256:eef2bf4429aab5bf7282f04202ec2810ca353dfa8a1e814f0e5bda48ecba26ee", "platform": { "architecture": "unknown", "os": "unknown" } }, { "mediaType": "application/vnd.oci.image.manifest.v1+json", "size": 1942, "digest": "sha256:8b10cc32983ca2268c98a237d5b09c672f814c88735e4a2d22c4d220304524dd", "platform": { "architecture": "arm64", "os": "linux", "variant": "v8" } }, { "mediaType": "application/vnd.oci.image.manifest.v1+json", "size": 841, "digest": "sha256:4cb00bc050e369334f5c0f0f5f201ea94c8b96f1000b0a0a71e3fd80f62414b5", "platform": { "architecture": "unknown", "os": "unknown" } }, { "mediaType": "application/vnd.oci.image.manifest.v1+json", "size": 1942, "digest": "sha256:0ffc1282d59f492a1a6538be841de55864d65e548a9973955ea5160049bbd26e", "platform": { "architecture": "ppc64le", "os": "linux" } }, { "mediaType": "application/vnd.oci.image.manifest.v1+json", "size": 841, "digest": "sha256:ecd671c19b239bb1d3453b9ea41e59bf6cf41c917567eed76208f520982cccb0", "platform": { "architecture": "unknown", "os": "unknown" } }, { "mediaType": "application/vnd.oci.image.manifest.v1+json", "size": 1940, "digest": "sha256:38c37dd186bb4491241971d8b4fa765191c2e9e83e73fc9077dff17cfb73f4a7", "platform": { "architecture": "s390x", "os": "linux" } }, { "mediaType": "application/vnd.oci.image.manifest.v1+json", "size": 841, "digest": "sha256:f5b0f953c4178ec4e51fd311dfafa3a1f1ff2e29412735adb28ca71d249d1fc8", "platform": { "architecture": "unknown", "os": "unknown" } } ] }