PLANNER-2932 fix impact assertion in constraint verifier

[RobJohansen]

JIRA

https://issues.redhat.com/browse/PLANNER-2932

Issue

Constraint Verifier gives unexpected result when verifying a constraint terminating with impact() (i.e. MIXED score type).

Resolution

Invert PENALTY and REWARD branches of switch.

[lucamolteni]

@RobJohansen there are a few failed test can you double check?

[RobJohansen]

@RobJohansen there are a few failed test can you double check?

Apologies, I've now seen the failing test and I'm re-assessing what the intention of the implementation is and whether this is a correct fix. I will update once I have done so, thanks.

[RobJohansen]

@lucamolteni It took a while to understand the intention of the tests in SingleConstraintAssertionTest but found the issue and rectified. Renamed "A" and "B" to "REWARD" and "PENALIZE" respectively, so that its a little clearer.

[lucamolteni]

@lucamolteni It took a while to understand the intention of the tests in SingleConstraintAssertionTest but found the issue and rectified. Renamed "A" and "B" to "REWARD" and "PENALIZE" respectively, so that its a little clearer.

Thanks, once we finalize this apache migration I'll merge it

[jstastny-cz]

The PR check has been mistakenly triggered for this PR again from testing location, you can disregard the failure, it was green earlier. @lucamolteni Sorry for the mess.