[LIVY-988] Support for escaping backtick from spark-submit arguments#417
Open
s0nskar wants to merge 2 commits intoapache:masterfrom
Open
[LIVY-988] Support for escaping backtick from spark-submit arguments#417s0nskar wants to merge 2 commits intoapache:masterfrom
s0nskar wants to merge 2 commits intoapache:masterfrom
Conversation
Author
|
cc: @pralabhkumar |
Contributor
|
Hi @s0nskar . I am looking into this . |
pralabhkumar
requested changes
Sep 2, 2023
server/src/test/scala/org/apache/livy/utils/SparkProcessBuilderSuite.scala
Show resolved
Hide resolved
server/src/main/scala/org/apache/livy/utils/SparkProcessBuilder.scala
Outdated
Show resolved
Hide resolved
Contributor
|
@s0nskar Build is failing because of checkstyle issue , please look into fixing this. |
|
@pralabhkumar My company uses AWS EMR for data processing, and EMR uses livy for job submissions. We ran into issue with backticks recently because the content in backticks gets removed. Would you mind following up on this PR and include it in the future releases? |
Author
|
@pralabhkumar PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes - #415
Adding support for escaping backticks from spark-submit arguments.
livy.server.escapeBackTicks(default: false)How was this patch tested?