Open
Conversation
|
thanks @namanagraw for reporting . Changes lgtm. thanks for providing the validation report also. Need to improve UT and please track UT's once after this commit. |
33e7935 to
e9c7d98
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Jetty web server dependency from version 9.4.50.v20221201 to 10.0.1 and updates the servlet API version from 3.1.0 to 4.0.1. The upgrade requires updating the request logging implementation to use Jetty 10's new API.
- Updated Jetty version from 9.4.50 to 10.0.1 in Maven dependencies
- Updated javax.servlet-api from 3.1.0 to 4.0.1 to match Jetty 10 requirements
- Refactored request logging to use Jetty 10's new CustomRequestLog and RequestLogWriter APIs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pom.xml | Updates Jetty and servlet API version properties |
| WebServer.scala | Migrates from deprecated NCSARequestLog to new CustomRequestLog implementation |
Comments suppressed due to low confidence (1)
server/src/main/scala/org/apache/livy/server/WebServer.scala:101
- The
setExtended(false)method call was removed during the migration to CustomRequestLog, but this configuration might be needed. In Jetty 10, extended logging is controlled by the log format string passed to CustomRequestLog constructor. Verify that the NCSA_FORMAT provides the desired level of logging detail.
requestLogWriter.setTimeZone("GMT")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
Tested in local
