LIVY-1028 scaladocs are not generated#504
LIVY-1028 scaladocs are not generated#504edwardcapriolo wants to merge 1 commit intoapache:masterfrom
Conversation
lmccay
left a comment
lmccay
left a comment
There was a problem hiding this comment.
@edwardcapriolo - this contains non-docs related changes. Please break this up so that any required revert would be clean for the intended changes.
The reason for this is nothing I do is getting merged so my master keeps accumulating "stuff". Is it fine otherwise? |
This is not a valid statement. Let's keep the issues separate, as I said, so that we can easily revert a code change without reverting a fix for docs being published. I don't have any context for reviewing the code changes that you have made there so can't really review it. Break them apart and provide context and manner of testing that was done and make sure it passes the precommits and we will be good to review it. Fixing the scala docs should be a no brainer review. |
2 participants
What changes were proposed in this pull request?
scaladocs for scala modules are not published.
How was this patch tested?
I ran the tests a number of times as I did this.
Please review https://livy.incubator.apache.org/community/ before opening a pull request.