This repository was archived by the owner on Feb 8, 2019. It is now read-only.
Open
Conversation
Basic implementation of GOSSIP-94, GOSSIP-95, GOSSIP-96 and GOSSIP-97 over GOSSIP-93
edwardcapriolo
suggested changes
Oct 26, 2017
Contributor
edwardcapriolo
left a comment
edwardcapriolo
left a comment
There was a problem hiding this comment.
Looks good overall change the spacing to two space for indent not tab. I will test out and make other comments.
| package org.apache.gossip.consistency; | ||
|
|
||
| public enum ConsistencyLevel { | ||
| ALL, |
Contributor
There was a problem hiding this comment.
Indenting is two spaces
| if(allowedFailures < 0) | ||
| { | ||
| cancelAll(futures); | ||
| System.out.println(ex.getStackTrace().toString()); |
Contributor
There was a problem hiding this comment.
Use loggers not printlny
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have created a basic implementation for GOSSIP-70 (https://issues.apache.org/jira/browse/GOSSIP-70). It covers GOSSIP-94, GOSSIP-95, GOSSIP-96 and GOSSIP-97 over Edward's implementation of GOSSIP-93.
I would love to get review comments from all of you to make this code better and to fix any errors.
Thanks
Ankur