-
Notifications
You must be signed in to change notification settings - Fork 38
Spelling #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Spelling #104
Changes from all commits
a83964c
6f96037
0b5090d
6c4656f
1d24f1d
8191c43
8289360
430f9db
28c01f1
53aee41
9d140b8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -179,15 +179,15 @@ def main(): | |
| parser.add_argument('-y', '--yaml', required=True, help="Pelicanconf YAML file") | ||
| args = parser.parse_args() | ||
|
|
||
| pelconf_yaml = args.yaml | ||
| sourcepath = os.path.dirname(os.path.realpath(pelconf_yaml)) | ||
| pelicanconf_yaml = args.yaml | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there's nothing horribly wrong w/ using short names, but there didn't seem to be a particularly good reason for it either. |
||
| sourcepath = os.path.dirname(os.path.realpath(pelicanconf_yaml)) | ||
| tool_dir = THIS_DIR | ||
|
|
||
| if os.path.exists(pelconf_yaml): | ||
| print(f"found {pelconf_yaml}") | ||
| if os.path.exists(pelicanconf_yaml): | ||
| print(f"found {pelicanconf_yaml}") | ||
| settings_path = os.path.join(sourcepath, AUTO_SETTINGS) | ||
| builtin_plugins = os.path.join(tool_dir, os.pardir, "plugins") | ||
| generate_settings(pelconf_yaml, settings_path, [builtin_plugins], sourcepath) | ||
| generate_settings(pelicanconf_yaml, settings_path, [builtin_plugins], sourcepath) | ||
|
|
||
| if __name__ == "__main__": | ||
| main() | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,7 +50,7 @@ def main(): | |
| with open(file, 'r', encoding='utf-8') as infile: | ||
| contents = infile.read() | ||
|
|
||
| # This will contain the "globals" after executing the peliconconf.py. | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. typos otoh ... |
||
| # This will contain the "globals" after executing the pelicanconf.py. | ||
| # Note: allow all builtins (by virtue of NOT inserting a __builtins__ | ||
| # value into this dictionary. We have no concerns about builtin usage. | ||
| values = { } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| # Plugin Architecture | ||
|
|
||
| The plugins used operate at various points in a pelican build. | ||
| Pelican uses signals at various points. These are documented [here](https://docs.getpelican.com/en/latest/plugins.html#list-of-signals). | ||
| Pelican uses [signals](https://docs.getpelican.com/en/latest/plugins.html#list-of-signals) at various points. | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an accessibility issue: Do not use
|
||
| At a high level consider the following sequence of events: | ||
|
|
||
| 1. Pelican Settings. Settings for a Pelican Build are in your Pelican Configuration | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a grammar error that I tripped on while looking at this workflow failure