Closed
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
Author
|
(fixed)
(the read-only token is sufficient, passed that in) |
raboof
force-pushed
the
run-tests-on-pr
branch
4 times, most recently
from
18489e6 to
29e5131
Compare
There are some specific tests for the stash action in `.github/workflows/stash-action-test.yml`. These might test particular scenario's, but we should also run the 'default' testset that includes the gateway tests
Member
Author
|
I think this was already merged along with #169 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a specific set of tests for the 'stash' action, which might still cover specific scenario's, but I think it would be good to do a basic run of 'all' tests as well - right now the gateway tests were not ran (and needed a fix)