Update README.md for the stash action#216
Merged
assignUser merged 3 commits intoapache:mainfrom Jul 6, 2025
Merged
Conversation
potiuk
reviewed
Jul 6, 2025
stash/README.md
Outdated
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: infrastructure-actions/stash/restore@v1 | ||
| - uses: apache/infrastructure-actions/stash/restore@main |
Member
There was a problem hiding this comment.
Might be a good idea to mention a commit hash - this is really the only way we should be using actions (and zizmor action and "CodeQL` security check will flag both tag an branch usage.
I think it would be better to follow this in the example.
potiuk
reviewed
Jul 6, 2025
potiuk
reviewed
Jul 6, 2025
Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Signed-off-by: Daniel Sahlberg <76568858+dsahlberg-apache-org@users.noreply.github.com>
assignUser
approved these changes
Jul 6, 2025
Member
assignUser
left a comment
assignUser
left a comment
There was a problem hiding this comment.
Sorry for the inconvenience and thanks for the PR! Hope the action works well for you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the apache/ prefix in uses so GHA find the action in the apache organisation. Change the used ref to @main, since there is no @v1 branch.
It took me, as a new user, a couple of tries to get it right. This changes should hopefully make it easier for new users.