Skip to content

Conversation

@Cpaulyz
Copy link
Contributor

@Cpaulyz Cpaulyz commented Nov 27, 2024

Description

https://timechor.feishu.cn/docx/GXnNdt3XIok3CQxBvwWcZxrnntd

This pull request introduces several new user-defined functions (UDFs) and corresponding integration tests for the IoTDB project. The changes include the addition of new scalar functions, updates to existing classes, and the creation of new test cases to ensure the functionality and robustness of the UDF management system.

New Scalar Functions:

  • ScalarFunctionExample: Implements a scalar function that checks if any input value is null and returns a boolean result.

Integration Tests:

  • IoTDBSQLFunctionManagementIT: Adds multiple test cases to verify the creation, display, and deletion of scalar functions, including handling of invalid function names and URIs.

@codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 15.75342% with 246 lines in your changes missing coverage. Please review.

Project coverage is 39.66%. Comparing base (5c84e68) to head (aac5938).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...n/execution/config/metadata/ShowFunctionsTask.java 0.00% 58 Missing ⚠️
...otdb/commons/udf/utils/UDFDataTypeTransformer.java 0.00% 38 Missing ⚠️
...olumn/udf/UserDefineScalarFunctionTransformer.java 0.00% 36 Missing ⚠️
...pache/iotdb/commons/udf/access/RecordIterator.java 0.00% 21 Missing ⚠️
...execution/relational/ColumnTransformerBuilder.java 0.00% 17 Missing ⚠️
...ne/plan/relational/metadata/TableMetadataImpl.java 0.00% 15 Missing ⚠️
...ion/config/executor/ClusterConfigTaskExecutor.java 0.00% 11 Missing ⚠️
...ain/java/org/apache/iotdb/commons/udf/UDFType.java 77.08% 11 Missing ⚠️
...yengine/plan/relational/sql/parser/AstBuilder.java 0.00% 9 Missing ⚠️
.../apache/iotdb/commons/udf/utils/TableUDFUtils.java 0.00% 9 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14223      +/-   ##
============================================
- Coverage     39.67%   39.66%   -0.02%     
  Complexity      185      185              
============================================
  Files          4321     4324       +3     
  Lines        274337   274588     +251     
  Branches      33316    33347      +31     
============================================
+ Hits         108847   108915      +68     
- Misses       165490   165673     +183     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lancelly
Copy link
Contributor

What a spectacular work 🦾! Fabulous design and implementation, LGTM! ⚡️⚡️🔥

@Cpaulyz Cpaulyz requested a review from JackieTien97 December 5, 2024 04:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@JackieTien97 JackieTien97 merged commit 09288da into master Dec 8, 2024
40 of 44 checks passed
@JackieTien97 JackieTien97 deleted the udsf branch December 8, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants