Skip to content

[Py-client] Print Dataset is closed error msg if user continues to fetch from it #14396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jt2594838 merged 1 commit into from
Dec 13, 2024
Merged

[Py-client] Print Dataset is closed error msg if user continues to fetch from it #14396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions iotdb-client/client-py/iotdb/Session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ def insert_str_record(self, device_id, timestamp, measurements, string_values):
)
measurements = list(filtered_measurements)
values = list(filtered_values)
if len(measurements) is 0 or len(values) is 0:
if len(measurements) == 0 or len(values) == 0:
logger.info("All inserting values are none!")
return
request = self.gen_insert_str_record_req(
Expand Down Expand Up @@ -556,7 +556,7 @@ def insert_aligned_str_record(
)
measurements = list(filtered_measurements)
values = list(filtered_values)
if len(measurements) is 0 or len(values) is 0:
if len(measurements) == 0 or len(values) == 0:
logger.info("All inserting values are none!")
return
request = self.gen_insert_str_record_req(
Expand Down Expand Up @@ -605,7 +605,7 @@ def insert_record(self, device_id, timestamp, measurements, data_types, values):
measurements = list(filtered_measurements)
data_types = list(filtered_data_types)
values = list(filtered_values)
if len(measurements) is 0 or len(data_types) is 0 or len(values) is 0:
if len(measurements) == 0 or len(data_types) == 0 or len(values) == 0:
logger.info("All inserting values are none!")
return
request = self.gen_insert_record_req(
Expand Down Expand Up @@ -651,7 +651,7 @@ def insert_records(
) = self.__filter_lists_by_values(
device_ids, times, measurements_lst, types_lst, values_lst
)
if len(device_ids) is 0:
if len(device_ids) == 0:
logger.info("All inserting values are none!")
return
if self.__enable_redirection:
Expand Down Expand Up @@ -734,7 +734,7 @@ def insert_aligned_record(
measurements = list(filtered_measurements)
data_types = list(filtered_data_types)
values = list(filtered_values)
if len(measurements) is 0 or len(data_types) is 0 or len(values) is 0:
if len(measurements) == 0 or len(data_types) == 0 or len(values) == 0:
logger.info("All inserting values are none!")
return
request = self.gen_insert_record_req(
Expand Down Expand Up @@ -780,7 +780,7 @@ def insert_aligned_records(
) = self.__filter_lists_by_values(
device_ids, times, measurements_lst, types_lst, values_lst
)
if len(device_ids) is 0:
if len(device_ids) == 0:
logger.info("All inserting values are none!")
return
if self.__enable_redirection:
Expand Down
3 changes: 3 additions & 0 deletions iotdb-client/client-py/iotdb/utils/IoTDBRpcDataSet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
from thrift.transport import TTransport
from iotdb.thrift.rpc.IClientRPCService import TSFetchResultsReq, TSCloseOperationReq
from iotdb.tsfile.utils.DateUtils import parse_int_to_date
from iotdb.utils.IoTDBConnectionException import IoTDBConnectionException
from iotdb.utils.IoTDBConstants import TSDataType

logger = logging.getLogger("IoTDB")
Expand Down Expand Up @@ -417,6 +418,8 @@ def result_set_to_pandas(self):
return df

def fetch_results(self):
if self.__is_closed:
raise IoTDBConnectionException("This DataSet is already closed")
self.__rows_index = 0
request = TSFetchResultsReq(
self.__session_id,
Expand Down
Loading