Skip to content

Conversation

@CRZbulabula
Copy link
Contributor

@CRZbulabula CRZbulabula commented Jul 8, 2025

This PR fixes the following bugs:

  1. The SQL show models <model_id> is invalid.
  2. Unify the lifecycle of user-defined models, corresponding to our state machine.

@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 39.08%. Comparing base (57f22e7) to head (a803553).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...gnode/procedure/impl/model/DropModelProcedure.java 0.00% 22 Missing ⚠️
.../apache/iotdb/confignode/manager/ModelManager.java 0.00% 4 Missing ⚠️
...ache/iotdb/commons/client/ainode/AINodeClient.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #15890   +/-   ##
=========================================
  Coverage     39.08%   39.08%           
  Complexity      198      198           
=========================================
  Files          4847     4847           
  Lines        315790   315796    +6     
  Branches      39657    39657           
=========================================
+ Hits         123436   123442    +6     
  Misses       192354   192354           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CRZbulabula CRZbulabula force-pushed the fix-model-manage-bugs branch from 6e63bd1 to 40b7f13 Compare July 9, 2025 01:52
@CRZbulabula CRZbulabula changed the title [AINode] Fix SQL bug show models <model_id> [AINode] Fix model management bugs Jul 9, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2025

@CRZbulabula CRZbulabula merged commit 0a0ec3f into master Jul 9, 2025
60 of 61 checks passed
@CRZbulabula CRZbulabula deleted the fix-model-manage-bugs branch July 9, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant