Skip to content

Conversation

@JackieTien97
Copy link
Contributor

This pull request introduces a new configuration option for setting the DataNode memory proportion, updates related interfaces and test setups to use this option, and refines a utility import in the query engine code. The main changes add the new setDataNodeMemoryProportion method to configuration classes and update test classes to utilize this new setting, while also cleaning up a dependency in the LastQueryScanNode class.

Configuration enhancements:

  • Added the setDataNodeMemoryProportion method to the CommonConfig interface and its implementations (MppCommonConfig, MppSharedCommonConfig, RemoteCommonConfig) to allow setting DataNode memory proportions programmatically. [1] [2] [3] [4]

Test setup updates:

  • Updated test classes (IoTDBOrderByIT, IoTDBAsofJoinTableIT) to use the new setDataNodeMemoryProportion method, ensuring that tests properly configure DataNode memory settings alongside existing query memory settings. [1] [2]

Dependency cleanup:

  • Replaced usage of StringUtil.isNotBlank from Jetty with StringUtils.isNotBlank from Apache Commons Lang in LastQueryScanNode, and removed the unnecessary Jetty import. [1] [2]

@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.95%. Comparing base (854f1dc) to head (9f866e9).
⚠️ Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
...ngine/plan/planner/plan/node/PlanGraphPrinter.java 0.00% 1 Missing ⚠️
...an/planner/plan/node/source/LastQueryScanNode.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #16109   +/-   ##
=========================================
  Coverage     38.95%   38.95%           
  Complexity      198      198           
=========================================
  Files          4876     4876           
  Lines        318207   318218   +11     
  Branches      40132    40132           
=========================================
+ Hits         123951   123956    +5     
- Misses       194256   194262    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 6, 2025

@JackieTien97 JackieTien97 merged commit 950c6a7 into master Aug 8, 2025
30 of 32 checks passed
@JackieTien97 JackieTien97 deleted the TinyFix branch August 8, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants