Skip to content

Conversation

@shuwenwei
Copy link
Member

@shuwenwei shuwenwei commented Aug 6, 2025

Description

Skip TTL check when there is no TTL and no mods file in the data region

@shuwenwei shuwenwei changed the title Skip TTL check when there is no ttl in the data region and no mods file Skip TTL check when there is no TTL in the data region and no mods file Aug 6, 2025
@shuwenwei shuwenwei changed the title Skip TTL check when there is no TTL in the data region and no mods file Skip TTL check when there is no TTLand no mods file in the data region Aug 6, 2025
@shuwenwei shuwenwei changed the title Skip TTL check when there is no TTLand no mods file in the data region Skip TTL check when there is no TTL and no mods file in the data region Aug 6, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 6, 2025

@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 44.77612% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.95%. Comparing base (88af0bc) to head (bed940d).
⚠️ Report is 37 commits behind head on master.

Files with missing lines Patch % Lines
.../iotdb/db/storageengine/dataregion/DataRegion.java 0.00% 32 Missing ⚠️
.../org/apache/iotdb/commons/schema/ttl/TTLCache.java 90.00% 3 Missing ⚠️
...g/apache/iotdb/confignode/persistence/TTLInfo.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16110      +/-   ##
============================================
+ Coverage     38.92%   38.95%   +0.03%     
  Complexity      198      198              
============================================
  Files          4876     4876              
  Lines        317412   318283     +871     
  Branches      40016    40150     +134     
============================================
+ Hits         123548   123996     +448     
- Misses       193864   194287     +423     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838 jt2594838 merged commit 77f1dcc into master Aug 7, 2025
39 of 40 checks passed
@jt2594838 jt2594838 deleted the skipTTLCheckInSomeCases branch August 7, 2025 02:41
shuwenwei added a commit that referenced this pull request Aug 8, 2025
…on (#16110)

* Skip TTL check when there is no ttl in the data region and no mods file

* check back quote
jt2594838 pushed a commit that referenced this pull request Aug 12, 2025
…on (#16110) (#16129)

* Skip TTL check when there is no ttl in the data region and no mods file

* check back quote
JackieTien97 pushed a commit that referenced this pull request Dec 16, 2025
…on (#16110)

* Skip TTL check when there is no ttl in the data region and no mods file

* check back quote

(cherry picked from commit 77f1dcc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants