Skip to content

Pipe: Delete the heartbeat event count in Remaining Count #16115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Caideyipi merged 3 commits into from
Aug 7, 2025
Merged

Pipe: Delete the heartbeat event count in Remaining Count #16115

Caideyipi merged 3 commits into from
Aug 7, 2025

Conversation

@luoluoyuyu
Copy link
Member

@luoluoyuyu luoluoyuyu commented Aug 6, 2025

Description

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

Caideyipi
Caideyipi approved these changes Aug 7, 2025
View reviewed changes
Copy link
Collaborator

@Caideyipi Caideyipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Caideyipi pushed a commit that referenced this pull request Aug 7, 2025
@luoluoyuyu
[To dev/1.3] Pipe: Delete the heartbeat event count in Remaining Count …
01dcf32 
…#16115 (#16116)

* Pipe: Delete the heartbeat event count in Remaining Count

* update

* delete getRemainingEvents function
@Caideyipi Caideyipi merged commit 275fe39 into apache:master Aug 7, 2025
35 of 37 checks passed
JackieTien97 pushed a commit that referenced this pull request Aug 11, 2025
@luoluoyuyu @JackieTien97
Pipe: Delete the heartbeat event count in Remaining Count (#16115)
065d0d7 
* Pipe: Delete the heartbeat event count in Remaining Count

* update

* delete getRemainingEvents function

(cherry picked from commit 275fe39)
@luoluoyuyu luoluoyuyu deleted the update-remaining-count branch August 12, 2025 01:13
Caideyipi pushed a commit to Caideyipi/iotdb that referenced this pull request Sep 2, 2025
@luoluoyuyu @Caideyipi
[To dev/1.3] Pipe: Delete the heartbeat event count in Remaining Count …
cfebbb4 
…apache#16115 (apache#16116)

* Pipe: Delete the heartbeat event count in Remaining Count

* update

* delete getRemainingEvents function
JackieTien97 pushed a commit that referenced this pull request Sep 2, 2025
@luoluoyuyu @JackieTien97
[To dev/1.3] Pipe: Delete the heartbeat event count in Remaining Count …
02e358b 
…#16115 (#16116)

* Pipe: Delete the heartbeat event count in Remaining Count

* update

* delete getRemainingEvents function
JackieTien97 pushed a commit that referenced this pull request Dec 16, 2025
@luoluoyuyu @JackieTien97
Pipe: Delete the heartbeat event count in Remaining Count (#16115)
c922fb4 
* Pipe: Delete the heartbeat event count in Remaining Count

* update

* delete getRemainingEvents function

(cherry picked from commit 275fe39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Caideyipi Caideyipi Caideyipi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luoluoyuyu @Caideyipi