[AINode] Refactor thrift integration#16323
Merged
CRZbulabula merged 3 commits intomasterfrom Sep 1, 2025
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16323 +/- ##
=========================================
Coverage 38.85% 38.85%
Complexity 198 198
=========================================
Files 4910 4910
Lines 322518 322518
Branches 40925 40925
=========================================
+ Hits 125317 125326 +9
+ Misses 197201 197192 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The current integration of the thrift module would introduce startup error when the thrift definition update. Specifically, to invoke the thrift api, we previously copy all thrift generated-python source to
ainode/thrift, then invoke api by importainode.thrift. However, in the thrift generated codes, invoke other thrift apis necessitates importiotdb.thrift. As a result, we should specify the specific python IoTDB version in 'pyproject.toml'. In this case, codes underainode/thriftcould be updated via maven compile, while the python IoTDB could not.To tackle this bug, we create a
iotdbmodule and copy all thrift generated-python source toiotdb/thrift. In this way, all thrift dependencies are up to date when compile.