Skip to content

[AINode] Refactor thrift integration#16323

Merged
CRZbulabula merged 3 commits intomasterfrom
fix-ain-ci
Sep 1, 2025
Merged

[AINode] Refactor thrift integration#16323
CRZbulabula merged 3 commits intomasterfrom
fix-ain-ci

Conversation

@CRZbulabula
Copy link
Contributor

@CRZbulabula CRZbulabula commented Sep 1, 2025

The current integration of the thrift module would introduce startup error when the thrift definition update. Specifically, to invoke the thrift api, we previously copy all thrift generated-python source to ainode/thrift, then invoke api by import ainode.thrift. However, in the thrift generated codes, invoke other thrift apis necessitates import iotdb.thrift. As a result, we should specify the specific python IoTDB version in 'pyproject.toml'. In this case, codes under ainode/thrift could be updated via maven compile, while the python IoTDB could not.

To tackle this bug, we create a iotdb module and copy all thrift generated-python source to iotdb/thrift. In this way, all thrift dependencies are up to date when compile.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2025

@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.85%. Comparing base (64c6900) to head (9f0965b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #16323   +/-   ##
=========================================
  Coverage     38.85%   38.85%           
  Complexity      198      198           
=========================================
  Files          4910     4910           
  Lines        322518   322518           
  Branches      40925    40925           
=========================================
+ Hits         125317   125326    +9     
+ Misses       197201   197192    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CRZbulabula CRZbulabula changed the title [AINode] Fix CI [AINode] Refactor thrift integration Sep 1, 2025
@CRZbulabula CRZbulabula merged commit 182a78a into master Sep 1, 2025
29 of 31 checks passed
@CRZbulabula CRZbulabula deleted the fix-ain-ci branch September 1, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments