[AINode] Update AINodeClient for DataNode to borrow #16647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRZbulabula
requested changes
Nov 3, 2025
iotdb-protocol/thrift-confignode/src/main/thrift/confignode.thrift
Outdated
Show resolved
Hide resolved
iotdb-protocol/thrift-confignode/src/main/thrift/confignode.thrift
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java
Outdated
Show resolved
Hide resolved
iotdb-protocol/thrift-confignode/src/main/thrift/confignode.thrift
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/client/ConfigNodeClient.java
Outdated
Show resolved
Hide resolved
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/client/ainode/AINodeClient.java
Outdated
Show resolved
Hide resolved
CRZbulabula
requested changes
Nov 6, 2025
...rg/apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java
Outdated
Show resolved
Hide resolved
iotdb-protocol/thrift-confignode/src/main/thrift/confignode.thrift
Outdated
Show resolved
Hide resolved
iotdb-protocol/thrift-confignode/src/main/thrift/confignode.thrift
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java
Outdated
Show resolved
Hide resolved
# Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java
Alchuang22-dev
force-pushed
the
updatenode2
branch
from
cd3b39a to
6ba848f
Compare
CRZbulabula
requested changes
Nov 15, 2025
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/client/AINodeClientFactory.java
Show resolved
Hide resolved
CRZbulabula
requested changes
Nov 16, 2025
integration-test/src/main/java/org/apache/iotdb/it/env/cluster/env/AbstractEnv.java
Outdated
Show resolved
Hide resolved
integration-test/src/main/java/org/apache/iotdb/it/env/remote/env/RemoteServerEnv.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/client/ainode/AINodeClient.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/client/ainode/AINodeClient.java
Outdated
Show resolved
Hide resolved
...rg/apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/iotdb/commons/consensus/iotv2/container/IoTV2GlobalComponentContainer.java
Outdated
Show resolved
Hide resolved
...rg/apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java
Outdated
Show resolved
Hide resolved
Contributor
|
LGTM~ |
JackieTien97
pushed a commit
that referenced
this pull request
Nov 26, 2025
(cherry picked from commit d49d7dd)
alpass163
pushed a commit
to alpass163/iotdb
that referenced
this pull request
Nov 28, 2025
CRZbulabula
pushed a commit
that referenced
this pull request
Dec 16, 2025
(cherry picked from commit d49d7dd)
CRZbulabula
added a commit
that referenced
this pull request
Dec 16, 2025
* [AINode] Refactor code base * [AINode] Implement concurrent inference framework (#16311) (cherry picked from commit 7b9ec7e) * [AINode] Fix bugs for SHOW LOADED MODELS (#16410) (cherry picked from commit 40b2b33) * [AINode] Add a batcher for inference (#16411) (cherry picked from commit 7734331) * [AINode][Bug fix] Concurrent inference (#16518) * trigger CI * bug fix 4 show loaded models (cherry picked from commit b4dde12) * [AINode] Concurrent inference bug fix (#16595) (cherry picked from commit 46a0c6a) * [AINode] Adjust the maximum inference input length (#16640) (cherry picked from commit 2c9064f) * [AINode] Fix bug of sundial and forecast udf (#16768) (cherry picked from commit 2b47be7) * [AINode] Package AINode via PyInstaller (#16707) (cherry picked from commit 49c625b) * [AINode] Enable AINode start as background (-d) (#16762) (cherry picked from commit 1ebb951) * [AINode] Update AINodeClient for DataNode to borrow (#16647) (cherry picked from commit d49d7dd) * [AINode] Fix bug that AINode cannot compile in Windows (#16767) (cherry picked from commit cd443ba) * [AINode] Delete poetry.lock for easier maintain different operating systems (#16793) (cherry picked from commit 50f92e4) * [AINode] Fix cp errors --------- Co-authored-by: Leo <[email protected]> Co-authored-by: jtmer <[email protected]> Co-authored-by: Zeyu Zhang <[email protected]>
CRZbulabula
pushed a commit
that referenced
this pull request
Dec 16, 2025
(cherry picked from commit d49d7dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the AINode client infrastructure to support direct communication between DataNode and AINode, removing the dependency on ConfigNode for AI-related operations such as model loading and inference. Should be reviewed by @CRZbulabula
Contents
AINodeClientAdded a new executeRemoteCallWithRetry() method for automatic retry and reconnection on Thrift transport failures, following the same design pattern as ConfigNodeClient.
Updated the loadModel(TLoadModelReq req) API to use this retry wrapper for improved resilience.
Simplified connection lifecycle management (init(), close()) to ensure stable client reuse via AINodeClientManager.
ClusterConfigTaskExecutorReplaced indirect ConfigNode RPCs with direct calls to AINodeClientManager.borrowClient(TEndPoint) for model operations (currently loadModel as an example).
Ensured the DataNode→AINode invocation flow mirrors the ConfigNode client style while maintaining compatibility with existing client pooling.
Updated Thrift imports to use org.apache.iotdb.ainode.rpc.thrift.* instead of org.apache.iotdb.confignode.rpc.thrift.*.
AINodeClientManagerImpact
DataNode can now directly send AI-related requests (e.g., model load/unload, inference) to AINode without routing through ConfigNode.
Next Steps
Extend the same direct invocation pattern (AINodeClientManager.borrowClient()) to other AI APIs:
unloadModel, showModel, showLoadedModel, showAIDevices, createTraining, and getModelInfo.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR
As former.