Skip to content

Conversation

@CRZbulabula
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the AINode start/stop scripts to support daemon mode and refactors the shutdown process for consistency. The key changes include adding a -d flag for daemon mode in both Windows and Unix start scripts, and renaming shutdown methods from shutdown() to stop() for naming consistency.

  • Added daemon mode support via -d flag to start AINode in the background
  • Renamed shutdown methods to stop() across Python modules for consistency
  • Fixed shutdown sequence to call handler.stop() in the RPC service

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
scripts/sbin/windows/start-ainode.bat Added daemon mode support with -d flag and conditional execution
scripts/sbin/start-ainode.sh Added daemon mode support with -d flag using nohup for background execution
iotdb-core/ainode/iotdb/ainode/core/rpc/service.py Added handler.stop() call in RPC service shutdown
iotdb-core/ainode/iotdb/ainode/core/rpc/handler.py Renamed shutdown() to stop() for consistency
iotdb-core/ainode/iotdb/ainode/core/manager/inference_manager.py Renamed shutdown() to stop() for consistency
iotdb-core/ainode/iotdb/ainode/core/inference/pool_controller.py Renamed shutdown() to stop() for consistency
iotdb-core/ainode/iotdb/ainode/core/ai_node.py Fixed retry logic with inverted condition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

@CRZbulabula CRZbulabula changed the title [AINode] Update start/stop scripts [AINode] Enable AINode start as background (-d) Nov 15, 2025
@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.72%. Comparing base (91e48f0) to head (9d51d50).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16762      +/-   ##
============================================
- Coverage     38.72%   38.72%   -0.01%     
  Complexity      207      207              
============================================
  Files          5005     5005              
  Lines        331852   331852              
  Branches      42202    42202              
============================================
- Hits         128526   128505      -21     
- Misses       203326   203347      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CRZbulabula CRZbulabula merged commit 1ebb951 into master Nov 15, 2025
37 of 39 checks passed
@CRZbulabula CRZbulabula deleted the enhance-start-stop-script-ain branch November 15, 2025 08:56
JackieTien97 pushed a commit that referenced this pull request Nov 26, 2025
alpass163 pushed a commit to alpass163/iotdb that referenced this pull request Nov 28, 2025
CRZbulabula added a commit that referenced this pull request Dec 16, 2025
CRZbulabula added a commit that referenced this pull request Dec 16, 2025
* [AINode] Refactor code base

* [AINode] Implement concurrent inference framework (#16311)

(cherry picked from commit 7b9ec7e)

* [AINode] Fix bugs for SHOW LOADED MODELS (#16410)

(cherry picked from commit 40b2b33)

* [AINode] Add a batcher for inference (#16411)

(cherry picked from commit 7734331)

* [AINode][Bug fix] Concurrent inference (#16518)

* trigger CI

* bug fix 4 show loaded models

(cherry picked from commit b4dde12)

* [AINode] Concurrent inference bug fix (#16595)

(cherry picked from commit 46a0c6a)

* [AINode] Adjust the maximum inference input length (#16640)

(cherry picked from commit 2c9064f)

* [AINode] Fix bug of sundial and forecast udf (#16768)

(cherry picked from commit 2b47be7)

* [AINode] Package AINode via PyInstaller (#16707)

(cherry picked from commit 49c625b)

* [AINode] Enable AINode start as background (-d) (#16762)

(cherry picked from commit 1ebb951)

* [AINode] Update AINodeClient for DataNode to borrow (#16647)

(cherry picked from commit d49d7dd)

* [AINode] Fix bug that AINode cannot compile in Windows (#16767)

(cherry picked from commit cd443ba)

* [AINode] Delete poetry.lock for easier maintain different operating systems (#16793)

(cherry picked from commit 50f92e4)

* [AINode] Fix cp errors

---------

Co-authored-by: Leo <[email protected]>
Co-authored-by: jtmer <[email protected]>
Co-authored-by: Zeyu Zhang <[email protected]>
CRZbulabula added a commit that referenced this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant