[AINode] Fix bug of sundial and forecast udf #16768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRZbulabula
requested changes
Nov 17, 2025
| elif past_length < token_num: | ||
| # TODO: Actually, we need to know the output_token_lens used in the last generation step. | ||
| # Sundial will pad the input when it is non-divisible, so we cannot use past_length to slice input_ids | ||
| input_ids = input_ids[:, -self.config.output_token_lens[0] :] |
Contributor
There was a problem hiding this comment.
Why change the computation of input_ids here?
Contributor
Author
There was a problem hiding this comment.
Because Sundial will pad the input when it is non-divisible, so we cannot use past_length to slice input_ids, it will slice more sequence than we expected.
yunbow30944
force-pushed
the
fix_forecast_and_sundial
branch
from
0dc23cf to
b18da36
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
JackieTien97
pushed a commit
that referenced
this pull request
Nov 26, 2025
(cherry picked from commit 2b47be7)
alpass163
pushed a commit
to alpass163/iotdb
that referenced
this pull request
Nov 28, 2025
CRZbulabula
pushed a commit
that referenced
this pull request
Dec 16, 2025
(cherry picked from commit 2b47be7)
CRZbulabula
added a commit
that referenced
this pull request
Dec 16, 2025
* [AINode] Refactor code base * [AINode] Implement concurrent inference framework (#16311) (cherry picked from commit 7b9ec7e) * [AINode] Fix bugs for SHOW LOADED MODELS (#16410) (cherry picked from commit 40b2b33) * [AINode] Add a batcher for inference (#16411) (cherry picked from commit 7734331) * [AINode][Bug fix] Concurrent inference (#16518) * trigger CI * bug fix 4 show loaded models (cherry picked from commit b4dde12) * [AINode] Concurrent inference bug fix (#16595) (cherry picked from commit 46a0c6a) * [AINode] Adjust the maximum inference input length (#16640) (cherry picked from commit 2c9064f) * [AINode] Fix bug of sundial and forecast udf (#16768) (cherry picked from commit 2b47be7) * [AINode] Package AINode via PyInstaller (#16707) (cherry picked from commit 49c625b) * [AINode] Enable AINode start as background (-d) (#16762) (cherry picked from commit 1ebb951) * [AINode] Update AINodeClient for DataNode to borrow (#16647) (cherry picked from commit d49d7dd) * [AINode] Fix bug that AINode cannot compile in Windows (#16767) (cherry picked from commit cd443ba) * [AINode] Delete poetry.lock for easier maintain different operating systems (#16793) (cherry picked from commit 50f92e4) * [AINode] Fix cp errors --------- Co-authored-by: Leo <[email protected]> Co-authored-by: jtmer <[email protected]> Co-authored-by: Zeyu Zhang <[email protected]>
CRZbulabula
pushed a commit
that referenced
this pull request
Dec 16, 2025
(cherry picked from commit 2b47be7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test
Before
After