Skip to content

Comments

Pipe: Implemented the processTabletWithCollect api with tablet collector#16930

Merged
Caideyipi merged 9 commits intomasterfrom
pipe-api
Dec 22, 2025
Merged

Pipe: Implemented the processTabletWithCollect api with tablet collector#16930
Caideyipi merged 9 commits intomasterfrom
pipe-api

Conversation

@Caideyipi
Copy link
Collaborator

@Caideyipi Caideyipi commented Dec 19, 2025

Description

Now the pipe processor can only collect by rows, which is not friendly for some whole tablet related changes. This PR has implemented tablet collector to collect tablets and transform them to events directly.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 54.90196% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.16%. Comparing base (ca26dd3) to head (2e6fc21).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...ent/common/tablet/PipeRawTabletEventConverter.java 56.52% 10 Missing ⚠️
...mon/tablet/PipeInsertNodeTabletInsertionEvent.java 0.00% 5 Missing ⚠️
...parser/TabletInsertionEventTablePatternParser.java 0.00% 5 Missing ⚠️
.../pipe/event/common/tablet/PipeTabletCollector.java 81.81% 2 Missing ⚠️
...tdb/db/pipe/event/common/row/PipeRowCollector.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #16930   +/-   ##
=========================================
  Coverage     39.16%   39.16%           
  Complexity      212      212           
=========================================
  Files          5048     5050    +2     
  Lines        334961   334989   +28     
  Branches      42685    42689    +4     
=========================================
+ Hits         131179   131205   +26     
- Misses       203782   203784    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

@Caideyipi Caideyipi merged commit 2bdbd41 into master Dec 22, 2025
31 checks passed
@Caideyipi Caideyipi deleted the pipe-api branch December 22, 2025 02:34
jt2594838 pushed a commit that referenced this pull request Dec 24, 2025
…tablet collector (#16941)

* Pipe: Implemented the processTabletWithCollect api with tablet collector (#16930)

* patch

* fix

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants