OAK-12037 : remove usage of Guava's Monitor from oak-lucene #2660
Conversation
rishabhdaim
requested review from
fabriziofortino,
mbaedke,
reschke and
thomasmueller
|
| // timeout | ||
| break; | ||
| } | ||
| notCopyingCondition.awaitNanos(remaining); |
There was a problem hiding this comment.
This whole nano calculation seems clumsy. Why not just notCopyingCondition.await(timeoutMillis, TimeUnit.MILLISECONDS) ?
There was a problem hiding this comment.
AFAIK the thread could be woken up in some cases, and so a loop is needed, and so a calculation is needed.
| boolean notCopying = !isCopyInProgress(file); | ||
| while (!notCopying) { | ||
| final long deadline = System.nanoTime() + TimeUnit.MILLISECONDS.toNanos(timeoutMillis); | ||
| copyCompletionLock.lock(); |
There was a problem hiding this comment.
How is that working with the timeout?
There was a problem hiding this comment.
by following this logic, we ensure that we block for only an absolute time in future.
On each inner-loop iteration you recompute remaining = deadline - System.nanoTime()
This is to ensure that regardless of how many times the threads are woken, we only wait for timeoutMillis.
3 participants
No description provided.