OAK-12047 - CachingSegmentArchiveReader#readSegment should check if archive contains segment before looking up in the PersistentCache #2672
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ins segment before looking up in the PersistentCache
mreutegg
reviewed
Jan 6, 2026
Contributor
mreutegg
left a comment
mreutegg
left a comment
There was a problem hiding this comment.
The change looks good to me, but I'd like to see a test that validates the change.
…es not return a segment from the shared cache if that segment is not present in the archive.
Contributor
Author
Added a check in an existing test: 9f555b8 |
mreutegg
approved these changes
Jan 15, 2026
bhabegger
pushed a commit
to bhabegger/jackrabbit-oak
that referenced
this pull request
Jan 15, 2026
…rchive contains segment before looking up in the PersistentCache (apache#2672)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rationale here OAK-12047