Make Attachment Storage Optional for PostgreSQL Message Store #2837
Conversation
| public static final String JOOQ_REACTIVE_TIMEOUT = "jooq.reactive.timeout"; | ||
| public static final Duration JOOQ_REACTIVE_TIMEOUT_DEFAULT_VALUE = Duration.ofSeconds(10); | ||
| public static final String ATTACHMENT_STORAGE_ENABLED = "attachment.storage.enabled"; | ||
| public static final boolean ATTACHMENT_STORAGE_ENABLED_DEFAULT_VALUE = false; |
There was a problem hiding this comment.
For JMAP users this makes sens to have this true
Maybe we can keep the existing behaviour given we provide an easy option to opt out?
|
The current change do break the delete listener 
We can likely relax |
|
Test classes have been updated, and the default value is set to true. |
| .then(deleteAttachment(msgId, attachmentDAO)) | ||
| .then(postgresConfiguration.isAttachmentStorageEnabled() | ||
| ? deleteAttachment(msgId, attachmentDAO) | ||
| : Mono.empty()) |
There was a problem hiding this comment.
The conditional operator ain't really much used in James codebase. We usually prefer extracting this into a private method and using an explicit if condition.
There was a problem hiding this comment.
Ok. I’ll fix it right away.
…Listener Extract attachment deletion conditional logic into private method with explicit if condition, following James code style conventions.
|
So far latests fixes looks fine to me. Can this work be rebased and squashed so that we have a clean history ready for merge? 
Thanks by advance. |
4 participants
The parameter attachment.storage.enabled=false can be used to configure whether attachments are stored in the database.