MINOR: Deflake streams admin api describe streams group with short timeout #20320
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
bbejeck
reviewed
Aug 11, 2025
There was a problem hiding this comment.
Thanks for the PR @aliehsaeedii - overall LGTM - I'll kick off the build a few times to see if the flakiness is fixed, and either merge or discuss if we need to keep the test.
mjsax
reviewed
Aug 11, 2025
There was a problem hiding this comment.
What was the original purpose of the test? -- It's unclear to me, why creating a second KS instance help to stabilize the test. Can you elaborate?
If I read the test correctly, the idea is to get a timeout exception for a describe call -- what is the conditions when we would get a timeout exception? Group does not exist? Or something else?
| public void testDescribeStreamsGroupWithShortTimeout() { | ||
| public void testDescribeStreamsGroupWithShortTimeout() throws Exception { | ||
| cluster.createTopic(INPUT_TOPIC_2, 1, 1); | ||
| KafkaStreams streams2 = new KafkaStreams(topology(INPUT_TOPIC_2, OUTPUT_TOPIC_2), streamsProp(APP_ID_2)); |
| List<String> args = List.of("--bootstrap-server", bootstrapServers, "--describe", "--members", "--verbose", "--group", APP_ID, "--timeout", "1"); | ||
| Throwable e = assertThrows(ExecutionException.class, () -> getStreamsGroupService(args.toArray(new String[0])).describeGroups()); | ||
| assertEquals(TimeoutException.class, e.getCause().getClass()); | ||
|
|
||
| streams2.close(); | ||
| streams2.cleanUp(); |
There was a problem hiding this comment.
If we use try-with-resource, we can remove close() and put cleanUp() into finally-block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a
1mstimeout, the streams group description occasionallysucceeds. To check if this resolves the flakiness, I created the streams
group within the test itself. If this approach doesn't stabilize the
test, we should consider removing it altogether, since the original
intent behind the test may no longer be valid.
Reviewers: Bill Bejeck[email protected]