[WIP] KIP-966: Designated Leadership elections #20610
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add new field to ElectLeaderRequest add desiredLeaders to ElectLeadersRequest add designated election type fix test cases for new ElectLeaderRequest add TopicPartitionDesignated fix semantics add more error handling change error thrown Conflicts: core/src/main/scala/kafka/controller/KafkaController.scala core/src/test/scala/unit/kafka/utils/TestUtils.scala metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java tools/src/test/java/org/apache/kafka/tools/LeaderElectionCommandTest.java Avoided merging some of the test conflicts; kept TestUtils.scala changes.
- Actually implemented the code - Started creating some of the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to perform an unclean leadership election by designated a specific replica as the leader as part of the ElectLeadersRequest.